Opened 7 years ago

Closed 7 years ago

#4666 closed defect (fixed)

a "lego" message - Notifier.signup confirm plain.created account

Reported by: amire80 Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: Cc:

Description

Hi,

This translatable message is a "lego" message: https://translatewiki.net/wiki/Osm:Notifier.signup_confirm_plain.created_account/en

A "lego" message is a message that is concatenated with other strings in run-time. This is a very big problem for translation, because in many languages the word order is different from English.

I supposed that "OpenStreetMap" or something similar is added to it in the end. Please re-phrase this message so that the added string is added as a parameter and not necessarily added to the end of the sentence.

Change History (6)

comment:1 Changed 7 years ago by amire80

... And while you are fixing this, can you please edit the documentation for this message? Just go to https://translatewiki.net/wiki/Osm:Notifier.signup_confirm_plain.created_account/qqq

Edit the page, delete the current line with the link to the bug report, and write new documentation that explains to the translators where this message appears.

comment:3 Changed 7 years ago by Tom Hughes

These messages are tricky because they are part of a plain text email so there are line length limits involved in order to try and keep the email to 80 column lines...

comment:4 Changed 7 years ago by Shaun McDonald

A possible solution would be to run the result through the word_wrap method:

http://api.rubyonrails.org/classes/ActionView/Helpers/TextHelper.html#method-i-word_wrap

comment:5 Changed 7 years ago by Tom Hughes

I was looking at format_paragraph ;-)

The whole thing is a mess though - since Kai's latest changes we have four different paths with a horrendous amount of duplication and some of the lego is about trying to share bits of messages between the different paths.

comment:6 Changed 7 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

I've pushed a fix for this.

Note: See TracTickets for help on using tickets.