Ticket #4686 (closed defect: fixed)

Opened 17 months ago

Last modified 17 months ago

All diary entries' comments described to have at least 1 comment if user's language preference is FR

Reported by: skorasaurus Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: diary language Cc:

Description

When a user has 'fr' selected as their preferred language in their user settings (http://www.openstreetmap.org/user/INSERTUSERNAMEHERE/account ), diary entries that do not have any comments state on the main diary page that they have 1 comment on them, even if they do not have any comments on them (see the attachment OSM-diary-entry-FR.png as an example).

I've seen this occur on the main french,english, and German diary pages.

Entries that have 1 or more comments have the correct number of comments listed.

Users who have en-US,en set as their preferred language have 0 comments listed if they do not have any comments on their entry.

Attachments

OSM-diary-entry-FR.png Download (113.3 KB) - added by skorasaurus 17 months ago.

Change History

Changed 17 months ago by skorasaurus

comment:1 Changed 17 months ago by skorasaurus

This problem also occurs if you visit a particular user's diary as well (for example) http://www.openstreetmap.org/user/skorasaurus/diary

comment:2 Changed 17 months ago by TomH

Well of course if it affects one diary list it will affect them all - it's all the same page just with different search criteria to select the entries to show.

My immediate guess would be that this is a translation issue.

comment:3 Changed 17 months ago by TomH

Yes, it's a combination of our fr locale rules:

 http://git.openstreetmap.org/rails.git/blob/HEAD:/config/locales/fr.yml#l345

which are a direct translation of the hardcoded "1" in the en rules:

 http://git.openstreetmap.org/rails.git/blob/HEAD:/config/locales/en.yml#l369

and the fr pluralization rules, which use the "one" string for zero:

 https://github.com/tomhughes/rails-i18n/blob/master/lib/rails_i18n/common_pluralizations/one_upto_two_other.rb

comment:4 Changed 17 months ago by TomH

  • Status changed from new to closed
  • Resolution set to fixed

Fixed.

Note: See TracTickets for help on using tickets.