Opened 6 years ago

Closed 6 years ago

#4719 closed defect (fixed)

Search seems to be buggy, building has set street name, search shows wrong street

Reported by: mappy123 Owned by: geocoding@…
Priority: major Milestone:
Component: nominatim Version:
Keywords: Cc: ESYSCODER

Description

Hello,

see here:

http://forum.openstreetmap.org/viewtopic.php?pid=297973#p297973

when searching for this supermarket I have two issues:

  • it is not found if searched by the name of the supermarket (I consinder that as major)
  • if searched for supermarket it is found but it shows wrong address, though the building has an address set

Thanks,M.

Change History (4)

comment:1 Changed 6 years ago by Sarah Hoffmann

For reference, the supermarket in question is this ALDI: http://nominatim.openstreetmap.org/details.php?osmtype=W&osmid=194775094 and the road it should belong to is South Ardmore Avenue: http://nominatim.openstreetmap.org/details.php?osmtype=W&osmid=22109380

Itś not really an error if you cannot find the supermarket using the right address when Nominatim assigned the wrong one. The reason that the road is not assigned correctly is that South Ardmore Avenue is rather long and the ALDI happens to be at the very end. The current search radius in getNearestNamedRoadFeature() is 0.01 and the centroid of the road is 0.015 away. Could increase the limit as a quick fix. I don't think it will hurt performance much. Naturally, it won't solve the problem for the general case. Any other ideas?

comment:2 Changed 6 years ago by mappy123

extending the search radius might help, but having it extend it might miss the next search. I have figured for quite a lot of buildings now the same issue. If you need more examples I can give quite a few. I would rather fix that the addr:street tag is used, I wonder why the closest street is searched if the addr:street tag is set correctly for this building. So no search needed at all in the proximity, which should be best for performance.

comment:3 Changed 6 years ago by ESYSCODER

Cc: ESYSCODER added

comment:4 Changed 6 years ago by Sarah Hoffmann

Resolution: fixed
Status: newclosed

Fixed, nearest road search now takes the full street into account.

This fixed is deployed on osm.org but as the database has not been reimported it will only have an effect on newly created or modified roads.

Note: See TracTickets for help on using tickets.