Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Search seems to be buggy, building has set street name, search shows wrong street #4719

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: mappy123
[Submitted to the original trac issue database at 2.28pm, Wednesday, 12th December 2012]

Hello,

see here:

http://forum.openstreetmap.org/viewtopic.php?pid=297973#p297973

when searching for this supermarket I have two issues:

  • it is not found if searched by the name of the supermarket (I consinder that as major)
  • if searched for supermarket it is found but it shows wrong address, though the building has an address set

Thanks,M.

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 8.48pm, Thursday, 13th December 2012]

For reference, the supermarket in question is this ALDI: http://nominatim.openstreetmap.org/details.php?osmtype=W&osmid=194775094 and the road it should belong to is South Ardmore Avenue: http://nominatim.openstreetmap.org/details.php?osmtype=W&osmid=22109380

It not really an error if you cannot find the supermarket using the right address when Nominatim assigned the wrong one. The reason that the road is not assigned correctly is that South Ardmore Avenue is rather long and the ALDI happens to be at the very end. The current search radius in getNearestNamedRoadFeature() is 0.01 and the centroid of the road is 0.015 away. Could increase the limit as a quick fix. I don't think it will hurt performance much. Naturally, it won't solve the problem for the general case. Any other ideas?

@openstreetmap-trac
Copy link
Author

Author: mappy123
[Added to the original trac issue at 4.26pm, Sunday, 16th December 2012]

extending the search radius might help, but having it extend it might miss the next search. I have figured for quite a lot of buildings now the same issue. If you need more examples I can give quite a few. I would rather fix that the addr:street tag is used, I wonder why the closest street is searched if the addr:street tag is set correctly for this building. So no search needed at all in the proximity, which should be best for performance.

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 6.42am, Wednesday, 10th April 2013]

Fixed, nearest road search now takes the full street into account.

This fixed is deployed on osm.org but as the database has not been reimported it will only have an effect on newly created or modified roads.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant