Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Duplicating segments & nodes #476

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Duplicating segments & nodes #476

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Assignees
@openstreetmap-trac
Labels
Component: potlatch (flash editor) Priority: major Resolution: fixed Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: dmgroom[at]gmail.com
[Submitted to the original trac issue database at 5.30pm, Monday, 21st May 2007]

I'm not sure under what circumstances this occurs, and it may be when I myself do something wrong, but I have noticed duplicated nodes, and segments.

Occasionally I have noticed these duplicated segments form a way as well.

It is possible that these occur when either a way is split using Potlatch, or when a new way is joined onto an existing one with a new node. (maybe its not exactly the fault of Potlatch but due to the server being unresponsive [lots of 500 Internal server Errors being reported by JOSM today] and not all of Potlatch's edits get uploaded to the server?)
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: richard[at]systemeD.net
[Added to the original trac issue at 1.53pm, Wednesday, 23rd May 2007]

It seems likely that this happens when the server is slow.

When Potlatch uploads a new way, the sequence goes something like this:

  1. Potlatch SWF sends "putway" message to server
  2. Server creates any nodes not in the previous version of the way
  3. Server creates any segments not in the previous version of the way
  4. Server deletes any nodes and segments not in the new version of the way
  5. Server saves way_segments records to link the segments together as a way
  6. Server returns "ok" and new way/node/segment IDs
  7. Potlatch SWF updates its (internal) way object with the new details

This means that if the server is slow, and the user edits a way twice in succession, the nodes and segments will be created twice - because the second "putway" will be sent before the object has been updated in step 6.

Probably the best way to fix this is for Potlatch only to send "putway" for a given way when all previous putways on that way have been successfully returned.

@openstreetmap-trac
Copy link
Author

Author: richard[at]systemeD.net
[Added to the original trac issue at 8.12pm, Monday, 28th May 2007]

Above problem hopefully fixed in r3049, please test (once deployed!) and reopen if not satisfactory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: potlatch (flash editor) Priority: major Resolution: fixed Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac