Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4797 closed defect (invalid)

number of edits/user not correctly display

Reported by: dieterdreist Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: user edit number amount Cc:

Description

It seems the displayed number edits per user is currently broken, e.g. here there is a display of 2 edits, but the user has only one edit: http://www.openstreetmap.org/user/erilis (when you click on the 2 edits)

Change History (6)

comment:1 Changed 6 years ago by Tom Hughes

Resolution: invalid
Status: newclosed

No it's not - that user just has an empty changeset which is hidden in his edit list.

comment:2 in reply to:  1 Changed 6 years ago by ppawel@…

Replying to TomH:

No it's not - that user just has an empty changeset which is hidden in his edit list.

Wouldn't that be the definition of "broken" for this functionality? I mean, the counter shows one thing, the list another without any explanation... Closing as "invalid" does not seem like the best solution to this - IMHO at the very least this issue should be kept on file for reference since it *is* a bug.

Speaking of a solution for this - I guess some code would be needed around edits counter cache (if we are to stick with this implementation), e.g.

http://blog.douglasfshearer.com/post/17495285851/custom-counter-cache-with-conditions

But that seems to issue additional select on every update - not sure if this is feasible (although if there is a btree index on user_id in the changesets table then it should be pretty quick?).

comment:3 Changed 6 years ago by Tom Hughes

There's already a bug for that, so we don't need a second.

comment:4 Changed 6 years ago by Tom Hughes

I would also argue that having the counter hide some of the changesets would clearly be wrong - personally I would just stop hiding them in the list.

comment:5 in reply to:  3 Changed 6 years ago by ppawel@…

Replying to TomH:

There's already a bug for that, so we don't need a second.

Can you link to that bug? I was only able to find #4785 which is closed as well.

Last edited 6 years ago by ppawel@… (previous) (diff)

comment:6 Changed 6 years ago by Tom Hughes

Don't know which one is was offhand but I know it came up in the last few weeks.

Yes - the one you found is it, and as I explained it is not realistically fixable.

Note: See TracTickets for help on using tickets.