number of edits/user not correctly display #4797
Comments
Author: TomH No it's not - that user just has an empty changeset which is hidden in his edit list. |
Author: ppawel[at]fastmail.fm Replying to [comment:1 TomH]:
Wouldn't that be the definition of "broken" for this functionality? I mean, the counter shows one thing, the list another without any explanation... Closing as "invalid" does not seem like the best solution to this - IMHO at the very least this issue should be kept on file for reference since it is a bug. Speaking of a solution for this - I guess some code would be needed around edits counter cache (if we are to stick with this implementation), e.g. http://blog.douglasfshearer.com/post/17495285851/custom-counter-cache-with-conditions But that seems to issue additional select on every update - not sure if this is feasible (although if there is a btree index on user_id in the changesets table then it should be pretty quick?). |
Author: TomH There's already a bug for that, so we don't need a second. |
Author: TomH I would also argue that having the counter hide some of the changesets would clearly be wrong - personally I would just stop hiding them in the list. |
Author: ppawel[at]fastmail.fm Replying to [comment:3 TomH]:
Can you link to that bug? I was only able to find #4785 which is closed as well. |
Author: TomH Don't know which one is was offhand but I know it came up in the last few weeks. Yes - the one you found is it, and as I explained it is not realistically fixable. |
Reporter: dieterdreist
[Submitted to the original trac issue database at 3.19am, Tuesday, 26th February 2013]
It seems the displayed number edits per user is currently broken, e.g. here there is a display of 2 edits, but the user has only one edit: http://www.openstreetmap.org/user/erilis (when you click on the 2 edits)
The text was updated successfully, but these errors were encountered: