Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Wikipedia Link with Anchor - uselang parameter placed incorrect #4802

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: _al
[Submitted to the original trac issue database at 6.21pm, Thursday, 28th February 2013]

Example: Wikipedia link of [http://www.openstreetmap.org/browse/way/191972319 node 191972319].

If the link references an anchor and the uselang parameter is added at the end, this makes the anchor reference disfunctional, like
http://de.wikipedia.org/wiki/Liste_der_denkmalgesch%C3%BCtzten_Objekte_in_Wien/Penzing#objektid-25043?uselang=en

The uselang parameter should be added before the anchor, like
http://de.wikipedia.org/wiki/Liste_der_denkmalgesch%C3%BCtzten_Objekte_in_Wien/Penzing?uselang=en#objektid-25043

/al

@openstreetmap-trac
Copy link
Author

Author: erictheise
[Added to the original trac issue at 4.08am, Monday, 1st April 2013]

Fix for this in openstreetmap/openstreetmap-website#223

@openstreetmap-trac
Copy link
Author

Author: Kalten666
[Added to the original trac issue at 6.42pm, Monday, 6th January 2014]

A fix: only slightly adapted by myself, following the example of [[http://stackoverflow.com/users/2767755/arup-rakshit|Arup Rakshit]] on [[http://stackoverflow.com/]] in his answer to the question [[http://stackoverflow.com/questions/16623421#16623769|Ruby, How to add a param to an URL that you don't know if it has any other param already]].

git-patch: see attached file commit-5377db8

I did test the mechanism, but I did not test it in the system of the webserver! Pray do this for me prior to committing that patch!

ru, Kalten666

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 12.34am, Saturday, 1st March 2014]

Fixed by [changeset:1873478/rails].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant