Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Building attached to nameless street cannot be found by address #4877

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: Dmitriy.Ovdienko[at]gmail.com
[Submitted to the original trac issue database at 3.01am, Sunday, 9th June 2013]

I type "EPAM" in the search box on the osm.org and press Return button.

I expect to see:
EPAM Systems, 14, Kudriashova Street, Solomianka, Solomianskyi district, Kyiv, 01032, Ukraine

In fact search returns:
EPAM Systems, 14, Solomianka, Solomianskyi district, Kyiv, 01032, Ukraine.

"Kudriashova Street" is missed.

Also Search cannot find this building if you type "EPAM, Ukraine" or "EPAM, Kyiv"

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 12.37pm, Tuesday, 11th June 2013]

You can fix the missing street by adding an addr:street tag to your building. See [http://wiki.openstreetmap.org/wiki/Key:addr wiki] for more information.

The second issue about "EPAM, Ukraine" looks like it needs fixing in Nominatim. The object doesn't have address tokens in the search index, presumably because it is attached to a nameless street. I've taken the liberty to change the title of the bug report accordingly.

@openstreetmap-trac
Copy link
Author

Author: Dmitriy.Ovdienko[at]gmail.com
[Added to the original trac issue at 2.41pm, Tuesday, 11th June 2013]

lonvia, thank you for reply.

This building is attached to associatedStreet relation. I believe it is bad practice to use addr:street because street name can be changed.

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 2.56pm, Tuesday, 11th June 2013]

Indeed, sorry, I always miss those relations. So what happend is that Nominatim picked the one street from your associatedStreet relation that has no name, [http://www.openstreetmap.org/browse/way/182921658 this one], and then ran into the bug described above.

Nominatim could probably do better in finding a street with a name in that relation. However, making sure that all streets in the relation are correctly named sounds like good practice, too.

If you change the street now, please be aware that there is a known issue (#4619) with updates of associatedStreet relations, so I doubt Nominatim will pick up the change correctly.

@openstreetmap-trac
Copy link
Author

Author: Dmitriy.Ovdienko[at]gmail.com
[Added to the original trac issue at 9.34pm, Tuesday, 11th June 2013]

Now it works!!! Great.
BTW, Nominatim can take name of the relation. If it is epmty, then it should take street.

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 6.48pm, Monday, 28th April 2014]

Fixed in [changeset:6a1e599/nominatim].

@openstreetmap-trac
Copy link
Author

Author: Dmitriy.Ovdienko[at]gmail.com
[Added to the original trac issue at 9.00pm, Monday, 28th April 2014]

Awesome!!! Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant