Opened 6 years ago

Closed 5 years ago

#4883 closed defect (fixed)

Rhine relation (and possibly other rivers too) not included in the database (and not found in search on osm.org)

Reported by: aseerel4c26 Owned by: geocoding@…
Priority: major Milestone:
Component: nominatim Version:
Keywords: Cc: sommerluk

Description

(related to https://help.openstreetmap.org/questions/23189/bachlauf-richtig-erfassen-relation )

Why is the relation for river Rhine http://www.openstreetmap.org/browse/relation/123924 not known to Nominatim http://nominatim.openstreetmap.org/details?osmtype=R&osmid=123924 ? If one searches on osm.org for "Rhein" a result for the whole river would be far more useful than only single riverbank closed ways.

Change History (8)

comment:1 Changed 5 years ago by bdiscoe

Priority: minormajor

This is major. I just did a great deal of work to make a single relation for "Klamath River", only to discover that OSM site's search of "Klamath River" fails to find it. This is really bad. Rivers should be very easy to support.

comment:2 Changed 5 years ago by Sarah Hoffmann

As always: patches/pull requests are welcome.

comment:4 Changed 5 years ago by sommerluk

Cc: sommerluk added

comment:5 Changed 5 years ago by Sarah Hoffmann

Support for waterway relations added in osm2pgsql. However it works properly only for rivers that have exactly one linear stream. If there are breaks or side arms, a random linear section will be returned as geometry. Same fix needed as for sectioned roads.

Also need to figure out how to improve search results so that the river ways show up further down in the list (or not at all).

comment:6 Changed 5 years ago by Sarah Hoffmann

Resolution: fixed
Status: newclosed

Containing waterway ways are now excluded as of 052d219/nominatim, which should resolve this issue in terms of searching for waterway relations. Note that the DB on osm.org will still take a while to sort itself out. Search results still contain lots of waterway=riverbank ways. Those have been excluded from indexing now and should disappear gradually.

Geometry issue remains to be solved. Moved this to a separate issue.

comment:7 Changed 5 years ago by bdiscoe

Resolution: fixed
Status: closedreopened

This defect still exists today. For example, from the search box on www.openstreetmap.org:

Doing a nominatim search on "Rhine" does not return the Rhine relation (http://www.openstreetmap.org/relation/123924) in its results anywhere.

Doing a nominatim search on "Klamath River" does not return the Klamath River relation (http://www.openstreetmap.org/relation/3624126) in its results anywhere.

The Klamath has no "breaks or side arms", so that is not the problem. The search simply does not find it.

comment:8 Changed 5 years ago by Sarah Hoffmann

Resolution: fixed
Status: reopenedclosed

As stated in the final comment: the DB has not been reimported. So relations only become searchable at the moment when the relations are edited. There is a complete reimport planned in the near future which will make sure that all waterways are shown correctly. So please be patient until then.

Note: See TracTickets for help on using tickets.