Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Potlatch deleting attributes when saving #4890

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Potlatch deleting attributes when saving #4890

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments

Comments

@openstreetmap-trac
Copy link

Reporter: blahedo
[Submitted to the original trac issue database at 9.59pm, Monday, 1st July 2013]

If an entity is selected when you save in Potlatch, some of its attributes are deleted.

To reproduce:

  • Open Potlatch2 on a section of map
  • Highlight a road and make a modification to it (e.g. remove its "tiger:reviewed=no" attribute, or change its "highway" value)
  • While the road is still selected, press 's' to save

The save occurs, but several of the road's attributes disappear. I have verified that this happens even if multiple ways are selected, and if the 'save' button is clicked (rather than pressing 's'). If after this occurs to a way, the way is modified and saved again, additional attributes disappear.

Thinking it might have been a weird synch issue with Potlatch, I closed the changeset and reloaded Potlatch2, but the behaviour persisted.

I'm attaching before-and-after screenshots to show the behaviour. Between taking the "before" and taking the "after", the only thing I did was press 's' to save. Unless I'm completely misdiagnosing this, it is a fairly critical bug as it causes deletion of data. (Even if I'm misdiagnosing it, something is causing the deletion of data, and that's a problem.) A temporary workaround seems to be to make sure nothing is selected when you click 'save' or press 's', but it could just be that something is getting deleted and I'm not seeing it.

I'm running on Firefox 20, on Ubuntu 12.10, on iMac hardware.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 6.47am, Wednesday, 3rd July 2013]

This is intentional behaviour. On save, P2 strips a very small number of tags which are no longer used by the OSM community and now serve only to bloat the database (particularly some associated with the TIGER import). Other editors do the same. See http://git.openstreetmap.org/potlatch2.git/blob?f=net/systemeD/halcyon/connection/XMLConnection.as#l24 .

@openstreetmap-trac
Copy link
Author

Author: blahedo
[Added to the original trac issue at 3.12pm, Wednesday, 3rd July 2013]

Oh. Sorry. I thought I was just "lucky" that nothing important was deleted. From a UI perspective, it was a little alarming to see data just disappear like that, though. Glad it wasn't a problem....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant