Opened 6 years ago

Closed 6 years ago

#4913 closed defect (wontfix)

patch for applications/utils/perl_lib/Geo/Gpsdrive/getstreet.pm

Reported by: HamishB Owned by: Tom Hughes
Priority: minor Milestone:
Component: utils Version:
Keywords: gpsdrive Cc:

Description

Hi,

I'm a maintainer of the GpsDrive? software; our build links heavily into OSM. Our osm-svn-accessed devs have drifted away to new things over the years and there's a simple patch we need applied in osm svn. Could someone commit it for me or point me in the direction of getting svn access so I can look after it myself?

Index: applications/utils/perl_lib/Geo/Gpsdrive/getstreet.pm
===================================================================
--- applications/utils/perl_lib/Geo/Gpsdrive/getstreet.pm	(revision 29757)
+++ applications/utils/perl_lib/Geo/Gpsdrive/getstreet.pm	(working copy)
@@ -2,7 +2,7 @@
 #noch nicht alle variablen angepasst
 use LWP::UserAgent;
 use WWW::Mechanize;
-use Text::Query;
+
 use Getopt::Long; #maybe not needed any more
 use Pod::Usage;
 use DBI;

and also delete in svn the obsolete/conflicting applications/utils/export/osm2poidb/cmake/Modules/FindGTK2.cmake file?

thanks, Hamish

Change History (3)

comment:1 Changed 6 years ago by Tom Hughes

Resolution: wontfix
Status: newclosed

http://wiki.openstreetmap.org/wiki/Getting_The_Source#Getting_SVN_Commit_Access should tell you what to do, though ideally we would want the people who have been maintaining it until now to confirm that they are happy for you to take over.

comment:2 Changed 6 years ago by HamishB

Resolution: wontfix
Status: closedreopened

Resolution set to wontfix

I don't understand the reason here. please do fix, I even provided a patch. :)

I will try for svn access in future, I have a foggy memory of having tried long ago but not getting much response about it. I worked with the previous committers for some years on the project, so as long as they can be contacted a nod from them shouldn't be a problem. If they can't be found you probably won't have to look very far among osm core programmers to find someone who knows me well, I'm an old hand in the greater foss4geo community (and am your osgeo host co-admin for google summer of code this year).

regards, Hamish

comment:3 Changed 6 years ago by Tom Hughes

Resolution: wontfix
Status: reopenedclosed

The point is that I'm not a remote hands service here to type in svn commands for people.

On top of which I know nothing about this code and have no way to evaluate this patch and decide whether or not it is appropriate.

You need to talk to the people who maintain this software, not me, and either get them to commit your patch or to make you the maintainer and then you can request svn access to do it.

Note: See TracTickets for help on using tickets.