Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Constantly updated permalink in URL bar (hash style) spams browsing history in Firefox #4942

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 8 comments

Comments

@openstreetmap-trac
Copy link

Reporter: aseerel4c26
[Submitted to the original trac issue database at 2.01pm, Sunday, 11th August 2013]

Constantly updated permalink in URL bar (hash style) spams browsing history in Firefox. I don't like that. E.g. navigating back using the back button is impossible after you did a few drags and zooms. There IS already the "share" menu (by the way: why do I need to use "share" if I just want to do a bookmark for myself ?)

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 2.38pm, Sunday, 11th August 2013]

It only spams the global history - it does not affect the local history as used by the back/forward buttons.

The spamming of the global history was considered at length during the development of this feature and was decided not to be a significant problem.

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 2.46pm, Sunday, 11th August 2013]

I was nearly sure that I had seen the many entries also in the back button drop down. However, I cannot reproduce that now.

Re. spam in the browser history: not nice, though. What about making that spamming optional? I like to navigate back several page - the "History" menu of Firefox offers that with two clicks... now not anymore. Furthermore the history of a day of browsing osm.org maps gets full... really spammy. Other pages are pushed away in the history.

What about a checkbox in the share menu ("enable auto-permalink")? This could get filled by a user setting (for logged-in users).

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 3.23pm, Sunday, 11th August 2013]

Try this Greasemonkey script if you don't like the history spamming: http://userscripts.org/scripts/show/175199

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 11.40pm, Sunday, 11th August 2013]

Thanks lonvia! I have use misused [http://hackademix.net/2011/09/29/script-surrogates-quick-reference/ NoScript's surrogate scripts] for that. Works.

noscript.surrogate.osmorg.sources;@www.openstreetmap.org
noscript.surrogate.osmorg.replacement;document.addEventListener('DOMContentLoaded', function() { L.Hash.prototype.onMapMove = function() {}; }, false);

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 12.49pm, Monday, 12th August 2013]

That patch does not work for edit mode (Potlatch2). Does someone have a snippet for this?

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 3.58pm, Saturday, 30th November 2013]

The workaround does not work anymore.

[16:48:13.779] TypeError: L.Hash is undefined

And the page's JS code is minified ... Could not find out a new EventListener or something

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 1.52pm, Sunday, 1st December 2013]

Still a problem (with no workaround currently). Not every single map drag is a navigation action which would justify the cluttering of the user's browsing history.

@openstreetmap-trac
Copy link
Author

Author: mmd
[Added to the original trac issue at 8.58pm, Thursday, 21st May 2020]

Duplicate of openstreetmap/openstreetmap-website#506, closing here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant