Opened 6 years ago

Closed 6 years ago

#4954 closed defect (fixed)

Browse note page - the "Edit Note" link appends other co-ordinates to the URL and moves location away from the note

Reported by: SomeoneElse Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: notes addressbar Cc:

Description

I noticed this on this page:

http://www.openstreetmap.org/browse/note/10974 (I typed that into the address bar)

The "edit note" link shows up in the browser as:

http://www.openstreetmap.org/edit?note=10974

If I click that I'm taken to that link initially but then some sort of redirect occurs to

http://www.openstreetmap.org/edit?note=10974#map=16/53.1221/-1.4816

My default editor is P2.

(where 53.1221, -1.4816, zoom 16 is the location that I was last viewing the map on this browser before viewing the note page)

What used to happen was that the area around the note was shown in the editor. The note itself wasn't (which is arguably an omission, but that's an entirely separate issue)

For info the "edit area" link on the browse note page goes to:

http://www.openstreetmap.org/edit?bbox=-0.0419926643371582%2C51.58986944418806%2C-0.030319690704345707%2C51.5951750150238

which works as expected.

The browser is Firefox 22.0 on Windows 7.

Change History (3)

comment:1 Changed 6 years ago by jfire

I suspect this never worked correctly. I tested as far back as 3880ac5d (July 19) -- prior to any of the map UI or permalink changes -- and neither P2 nor iD go to the note's location.

comment:2 Changed 6 years ago by SomeoneElse

I can't comment on whether a URL of the form:

http://www.openstreetmap.org/edit?note=10974

has ever worked, but certainly the workflow of:

o receive email about note

o click on link in email (which has been of the form "More details about the note can be found at http://www.openstreetmap.org/browse/note/338." since at least April).

o Click edit link on that browse page

previously did go to the location of the note, rather than somewhere else.

It may have been purely by chance I guess (i.e. "something else" was updating the map location before the editor is invoked).

comment:3 Changed 6 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

Fixed in 6494747/rails.

Note: See TracTickets for help on using tickets.