Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

plugin.xml in osmosis-core contains bad version #5013

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 0 comments
Open

plugin.xml in osmosis-core contains bad version #5013

openstreetmap-trac opened this issue Jul 23, 2021 · 0 comments
Assignees
@openstreetmap-trac
Labels
Component: osmosis Priority: minor Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: Sergey Astakhov
[Submitted to the original trac issue database at 2.16pm, Wednesday, 16th October 2013]

In lastest version of osmosis (0.43.1) in file \org\openstreetmap\osmosis\core\plugin\plugin.xml (inside osmosis-core-0.43.1.jar) there is used version string (version="0.42-6-gf39a160-dirty"), that is not compatible with JPF, because it's supported only dot delimiter. As result you can't use "requires" section in custom plugin.xml

  <requires>
    <import plugin-id="org.openstreetmap.osmosis.core.plugin.Core"
            plugin-version="0.42" reverse-lookup="false"/>
  </requires>

Test case:

import junit.framework.TestCase;
import org.java.plugin.registry.Version;

public class PluginVersionTest extends TestCase
{
  public void testVersionCompatible()
  {
    Version coreVersion = Version.parse("0.42-6-gf39a160-dirty");
    Version requiredCoreVersion = Version.parse("0.42");

    assertTrue(coreVersion.isCompatibleWith(requiredCoreVersion));
  }
}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: osmosis Priority: minor Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac