Opened 6 years ago

Last modified 6 years ago

#5044 reopened defect

ctrl click does not work in user changeset list

Reported by: aseerel4c26 Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: Cc: mxn@…

Description

ctrl click (for new tab) is prevented (and instead loaded in the small sidebar) for the changeset links in http://www.openstreetmap.org/user/aseerel4c26/history

stop messing around with my user interface

Attachments (1)

ctrl.patch (995 bytes) - added by Tom Hughes 6 years ago.
Proof of concept patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Tom Hughes

I can make this work, but only by suppressing the inline load when ctrl is held down, and it's not at clear that it is correct to do that on all browsers... It is only really correct on those browsers where ctrl is defined to cause a load in a new window.

Changed 6 years ago by Tom Hughes

Attachment: ctrl.patch added

Proof of concept patch

comment:2 Changed 6 years ago by aseerel4c26

Thanks Tom, not tested of course.

However, you can imagine what that means for the current design. ;-) A mix of real links and fake links (even showing a URL as target - good side: at least allowing middle click to open a new tab).

comment:3 Changed 6 years ago by Minh Nguyễn

Cc: mxn@… added

comment:4 Changed 6 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

comment:5 Changed 6 years ago by aseerel4c26

Thanks Tom! Ctrl and Shift as modifier (and Firefox) work again as expected.

comment:6 Changed 6 years ago by dieterdreist

Resolution: fixed
Status: closedreopened

It is not completely working. It does work when you click on the changeset description but it doesn't on the changeset-number (while a single left click on the number gets you to the changeset). I was used to click on the changeset number and thought this didn't work at all, until I found this ticket and found out that the changeset-description link worked.

comment:7 Changed 6 years ago by Tom Hughes

This is a browser limitation - some browsers (at least Firefox, maybe others) do not generate click events for things which are not links if you are holding a modifier key. So it's out of our control really, at least unless we make that an actual link, but that still wouldn't help with the rest of the clickable area.

Note: See TracTickets for help on using tickets.