Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Remote edit links ignore shown object information ("browse" page) #5059

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Open

Comments

@openstreetmap-trac
Copy link

Reporter: aseerel4c26
[Submitted to the original trac issue database at 7.41am, Wednesday, 4th December 2013]

http://www.openstreetmap.org/node/123456 misses the edit link for exactly this node. Only edit links for the whole area are available. This mostly concerns editing via JOSM. Before the UI change there was only THIS node loaded via remote control. Not possible anymore - or am I missing something?!

Impact: loading takes longer, consumes more resources on server and client and it takes longer for me to find the right object in the editor.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.20pm, Thursday, 5th December 2013]

The edit button (and the entries in the edit menu) are all links to edit the specific node!

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.23pm, Thursday, 5th December 2013]

Looks like you are right about the result (for remote edit only) just not about the cause.

It's not that the link isn't for the object, it's that the remote edit code is ignoring the informatin in the link.

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 10.08pm, Thursday, 5th December 2013]

ah, thank you! In fact, I see it by hovering over the remote edit link. Yes, the remote edit does not work correctly.

Please note that it was not clear to me that the big edit button in fact changes - not related to the map display anymore but to the displayed object information. It should get another text then (to make this semantic change clear) - eg. "edit this object". If I remember correctly the old UI showed a clear description for those object edit links.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 12.25am, Friday, 6th December 2013]

I've applied a fix in [changeset:66aac9c/rails] to pass the selection details to JOSM but it still downloads the whole area because we still pass the bounding box as well.

That doesn't seem to be any different to the old code though - as far as I can see we have always passed the bounding box as well as the selection. In fact I'm not even sure you can tell it to only fetch the object - the documentation is here:

http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl#load_and_zoom_command

and says that the "select" parameter controls what is selected, not what is downloaded. You still have to give a bounding box for the download.

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 1.53am, Friday, 6th December 2013]

Oh, nice. I had a look, because I am not sure how it was:

At http://owl.apis.dev.openstreetmap.org/browse/node/89 the remote control link below the small map on the right (and also the edit link in the heading line - "node 89" and the edit link in the top menu) does call

GET http://127.0.0.1:8111/load_and_zoom?left=116.1222125&top=6.0116665&right=116.12241250000001&bottom=6.0114665&select=node89

which ''is'' a tiny bbox, yes . However, far less data than the big default viewport (maybe it was only like this because of the small map window on a object browse/detail page). AND the node gets selected (at least I think it was - the remote control from that page does not work for me (with those IDs and the default DB setup in JOSM). I think this should be findable in the old rails code.

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 5.03pm, Friday, 6th December 2013]

So, unless there will be another edit link (could be beneath the history link at the bottom of the sidepanel text) I think there is no possibility (UI-wise) for a smaller bounding box or a object-only download. A smaller bbox would be interesting if you want to edit a single node in a densely mapped city.

Object-only download to JOSM (could be interesting for geographically big ways or relations) is apparently only possible with the "import" command. Used by taginfo (via overpass api) and overpass turbo. Example link from taginfo: http://localhost:8111/import?url=http%3A%2F%2Foverpass-api.de%2Fapi%2Fxapi_meta%3F*%5Bbarrier%253Dpoller%5D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant