Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Facebook conspicuously missing from login choices #5087

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Closed

Facebook conspicuously missing from login choices #5087

openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments

Comments

@openstreetmap-trac
Copy link

Reporter: jidanni
[Submitted to the original trac issue database at 11.39pm, Saturday, 28th December 2013]

At least add a greyed out Facebook logo linking to an explanation of why OSM does not use it.

@openstreetmap-trac
Copy link
Author

Author: jidanni
[Added to the original trac issue at 11.44pm, Saturday, 28th December 2013]

Besides http://osm.org, also needed on
https://help.openstreetmap.org/account/signin/
etc. login pages.

@openstreetmap-trac
Copy link
Author

Author: pnorman
[Added to the original trac issue at 5.01am, Sunday, 29th December 2013]

Unlike the others listed, Facebook is not an OpenID provider.

For Facebook support, see openstreetmap/openstreetmap-website#153

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 3.46pm, Sunday, 29th December 2013]

More importantly, implementing Facebook requires creating a Facebook App, which requires accepting the Facebook TOS, and we are still awaiting legal clearance on that.

In any casem the github ticket covers this.

@openstreetmap-trac
Copy link
Author

Author: jidanni
[Added to the original trac issue at 11.55pm, Sunday, 29th December 2013]

I am saying it would be best to have a greyed out Facebook logo there in the row, with some mouseover/link saying why it is missing.

Just like if Hawaii was not there in the ocean at all, there could at least be some note put in its spot that we are aware of it, etc.

@openstreetmap-trac
Copy link
Author

Author: amm
[Added to the original trac issue at 10.38am, Tuesday, 31st December 2013]

Given that the code to support Facebook login (and MS/Windows account) already exists ( http://apmon.dev.openstreetmap.org/facebook-login/ ) and is more or less just awaiting legal approval to create an account and accept the TOS. Furthermore, it seems consensus that it should be approved, it just hasn't been made "official". It seems like the more productive way to just finally make that decision and deploy the code.

On the other hand, I should probably make sure that the code doesn't break if no OAuth settings are specified in the application.yml and that could result in a greyed out facebook login with an explanation. In this case the code could already be merged before OSMF comes with the formal approval and move things along.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant