Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5087 closed defect (duplicate)

Facebook conspicuously missing from login choices

Reported by: Dan Jidanni Jacobson Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: Cc:

Description

At least add a greyed out Facebook logo linking to an explanation of why OSM does not use it.

Change History (5)

comment:1 Changed 5 years ago by Dan Jidanni Jacobson

Besides http://osm.org, also needed on https://help.openstreetmap.org/account/signin/ etc. login pages.

comment:2 Changed 5 years ago by pnorman

Unlike the others listed, Facebook is not an OpenID provider.

For Facebook support, see https://github.com/openstreetmap/openstreetmap-website/pull/153

comment:3 Changed 5 years ago by Tom Hughes

Resolution: duplicate
Status: newclosed

More importantly, implementing Facebook requires creating a Facebook App, which requires accepting the Facebook TOS, and we are still awaiting legal clearance on that.

In any casem the github ticket covers this.

comment:4 in reply to:  3 Changed 5 years ago by Dan Jidanni Jacobson

I am saying it would be best to have a greyed out Facebook logo there in the row, with some mouseover/link saying why it is missing.

Just like if Hawaii was not there in the ocean at all, there could at least be some note put in its spot that we are aware of it, etc.

comment:5 Changed 5 years ago by amm

Given that the code to support Facebook login (and MS/Windows account) already exists ( http://apmon.dev.openstreetmap.org/facebook-login/ ) and is more or less just awaiting legal approval to create an account and accept the TOS. Furthermore, it seems consensus that it should be approved, it just hasn't been made "official". It seems like the more productive way to just finally make that decision and deploy the code.

On the other hand, I should probably make sure that the code doesn't break if no OAuth settings are specified in the application.yml and that could result in a greyed out facebook login with an explanation. In this case the code could already be merged before OSMF comes with the formal approval and move things along.

Note: See TracTickets for help on using tickets.