Opened 4 years ago

Last modified 4 years ago

#5307 new defect

Changeset comment email notification contains wrong details

Reported by: Larry0ua Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: Cc:


I recently noticed that when user leaves the message on the changeset I am interested in (either my changeset or changeset I've commented before) I receive an email where changeset link and the message text are both correct, but the date of the changeset and its comment are from other my changeset and are irrelevant.

See an attachment for the details: the first/second red underlines information irrelevant to the third underline (changeset link)

Attachments (1)

changeset_comment_mail.png (13.0 KB) - added by Larry0ua 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by Larry0ua

Attachment: changeset_comment_mail.png added

comment:1 Changed 4 years ago by Tom Hughes

If would help if you told us what the link should have been - ie what changeset it was really referring to.

comment:2 Changed 4 years ago by Tom Hughes

I can't see any problem here. The link is to changeset 17864507 and that comment does indeed exist on that changeset and was left at that time and that is the title of the changeset.

See where the title of the changeset is indeed "fix routing graph connectivity - UA-W" and the time of the first comment (hover over the time to see the exact value) is indeed 05:20 on 15th April.

Possibly the only real error is that the first line might be better phrased as:

"Sanjak left a a comment at 2015-04-15 05:20:23 UTC on your changeset titled 'fix routing graph connectivity - UA-W'"

Currently you might expect the time to be the time of the changeset rather than the comment due to the way it is phrased.

Note: See TracTickets for help on using tickets.