Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Changeset comment email notification contains wrong details #5305

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: Larry0ua
[Submitted to the original trac issue database at 9.04am, Thursday, 16th April 2015]

I recently noticed that when user leaves the message on the changeset I am interested in (either my changeset or changeset I've commented before) I receive an email where changeset link and the message text are both correct, but the date of the changeset and its comment are from other my changeset and are irrelevant.

See an attachment for the details: the first/second red underlines information irrelevant to the third underline (changeset link)

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.51am, Thursday, 16th April 2015]

If would help if you told us what the link should have been - ie what changeset it was really referring to.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.58am, Thursday, 16th April 2015]

I can't see any problem here. The link is to changeset 17864507 and that comment does indeed exist on that changeset and was left at that time and that is the title of the changeset.

See https://www.openstreetmap.org/changeset/17864507 where the title of the changeset is indeed "fix routing graph connectivity - UA-W" and the time of the first comment (hover over the time to see the exact value) is indeed 05:20 on 15th April.

Possibly the only real error is that the first line might be better phrased as:

"Sanjak left a a comment at 2015-04-15 05:20:23 UTC on your changeset titled 'fix routing graph connectivity - UA-W'"

Currently you might expect the time to be the time of the changeset rather than the comment due to the way it is phrased.

@openstreetmap-trac
Copy link
Author

Author: Andy Allan
[Added to the original trac issue at 1.25pm, Wednesday, 16th October 2019]

Fixed in openstreetmap/openstreetmap-website#2398

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant