Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Empty "upload GPX file" box on upload page does not give meaningful error #543

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: openstreetmap[at]phillipsuk.org
[Submitted to the original trac issue database at 12.34am, Friday, 21st September 2007]

On the GPX upload page (http://www.openstreetmap.org/traces/mine), if the "description" or "tags" box is empty, it returns an error. But, if the "Upload GPX File" box is empty (as it defaults to when this error appears), the following message appears:

Application error

Change this error message for exceptions thrown outside of an action (like in Dispatcher setups or broken Ruby code) in public/500.html

This appears to be a default Ruby error message - would be better to give the user a meaningful error message.

Also, would be better if the "Upload GPX File" box on the error page was already populated, or it was highlighted to make it obvious that the file needed to be re-selected.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 10.01am, Tuesday, 25th September 2007]

Umm... how could it be populated on the error page? are we supposed to guess what the name of your trace file is?

Obviously the 500 error is something that needs fixing - I suspect I know what the cause is and I'll try and look at it later on along with your other bug.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 10.02am, Tuesday, 25th September 2007]

Oh - I see what you mean - you want it populated on the original error page when there was no description. That might be hard, because I'm not sure if the browser sends the full pathname when doing a file upload (to be honest, it probably shouldn't from a security point of view).

@openstreetmap-trac
Copy link
Author

Author: openstreetmap[at]phillipsuk.org
[Added to the original trac issue at 10.37am, Tuesday, 25th September 2007]

I wasn't sure if the file name could be populated on the error page or not. I don't see that as a big issue, but I'd highlight the file box as well as the description box, so that it's obvious to the user that they have to re-enter the file name. Otherwise most people will just add a description and then get an error because there's no file name (that's what I did)

@openstreetmap-trac
Copy link
Author

Author: tomhughes
[Added to the original trac issue at 11.18pm, Tuesday, 25th September 2007]

(In [4709]) Improve consistency of trace upload forms and error handling.

Fixes #543 and #544.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant