Opened 12 years ago

Closed 12 years ago

#561 closed defect (fixed)

Page link bug when viewing GPS traces by tag on www.openstreetmap.org

Reported by: dkt Owned by: Tom Hughes
Priority: major Milestone:
Component: website Version:
Keywords: traces tags Cc:

Description

Hi,

Just noticed a bug when viewing traces by tag, e.g. http://www.openstreetmap.org/traces/tag/Germany, if you click on '2' to go to page 2, it links to http://www.openstreetmap.org/traces/page/2 but, it should be linking to http://www.openstreetmap.org/traces/tag/Germany/page/2 , i.e. appending the /page/2 to the current url including the tag query... As it stands, it takes you to page 2 of the 'All traces' view... I'm guessing that should be quick and easy to fix, but, not sure where to look to do it myself...

d

Change History (4)

comment:1 Changed 12 years ago by Steve Hosgood

I've got a rider to this: If you are viewing (say) http://www.openstreetmap.org/traces/page/2, and then click on "Germany" in the tags list to view just the Germany tags. What happens is that the /page/2 stuff gets appended to the "Germany" URL base, i.e. http://www.openstreetmap.org/traces/tag/Germany/page/2

But of course, there may not *be* a page 2 of "Germany" tags, and anyway it probably isn't appropriate to go there just because you were on page 2 of the general list. You should probably go to page 1 of the "Germany" tags, and then step through the pages of "Germany" tags (which brings you back to the original complaint!).

comment:2 Changed 12 years ago by Tom Hughes

Hmm... Not very helpful having that on the same ticket really as it is a separate issue and (unlike the original problem) should be easily fixable.

comment:3 Changed 12 years ago by Steve Hosgood

Sorry Tom, I figured that it was probably another case of the same underlying issue.

comment:4 Changed 12 years ago by tomhughes

Resolution: fixed
Status: newclosed

(In [5827]) Specify display_name and tag explicitly when generating pagination links as they don't always seem to be default correctly. Closes #561.

Note: See TracTickets for help on using tickets.