Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Page link bug when viewing GPS traces by tag on www.openstreetmap.org #561

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: dkt
[Submitted to the original trac issue database at 12.28pm, Friday, 12th October 2007]

Hi,

Just noticed a bug when viewing traces by tag, e.g. http://www.openstreetmap.org/traces/tag/Germany, if you click on '2' to go to page 2, it links to http://www.openstreetmap.org/traces/page/2 but, it should be linking to http://www.openstreetmap.org/traces/tag/Germany/page/2 , i.e. appending the /page/2 to the current url including the tag query... As it stands, it takes you to page 2 of the 'All traces' view... I'm guessing that should be quick and easy to fix, but, not sure where to look to do it myself...

d

@openstreetmap-trac
Copy link
Author

Author: Steve Hosgood
[Added to the original trac issue at 1.31pm, Tuesday, 30th October 2007]

I've got a rider to this: If you are viewing (say) http://www.openstreetmap.org/traces/page/2, and then click on "Germany" in the tags list to view just the Germany tags. What happens is that the /page/2 stuff gets appended to the "Germany" URL base, i.e. http://www.openstreetmap.org/traces/tag/Germany/page/2

But of course, there may not be a page 2 of "Germany" tags, and anyway it probably isn't appropriate to go there just because you were on page 2 of the general list. You should probably go to page 1 of the "Germany" tags, and then step through the pages of "Germany" tags (which brings you back to the original complaint!).

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 1.37pm, Tuesday, 30th October 2007]

Hmm... Not very helpful having that on the same ticket really as it is a separate issue and (unlike the original problem) should be easily fixable.

@openstreetmap-trac
Copy link
Author

Author: Steve Hosgood
[Added to the original trac issue at 12.15pm, Wednesday, 31st October 2007]

Sorry Tom, I figured that it was probably another case of the same underlying issue.

@openstreetmap-trac
Copy link
Author

Author: tomhughes
[Added to the original trac issue at 1.27am, Friday, 30th November 2007]

(In [5827]) Specify display_name and tag explicitly when generating pagination links
as they don't always seem to be default correctly. Closes #561.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant