Opened 12 years ago

Closed 11 years ago

#604 closed defect (fixed)

Junctions in tunnels / on bridges

Reported by: einarr Owned by: Jochen Topf
Priority: minor Milestone:
Component: osmarender Version:
Keywords: tunnel, junction, bridge Cc: simon@…, Knut Arne Bjørndal

Description

The arcades marking the beginning and end of a tunnel should not be shown if all the ways connected at a node have tunnel=yes.

For reference, see http://informationfreeway.org/?lat=69.65717098928287&lon=18.970146284989344&zoom=15&layers=B000F000 (or the attached tile from the same location) where there are two roundabouts in the tunnel system.

Attachments (2)

29691.png (5.0 KB) - added by einarr 12 years ago.
A tile illustrating the issue.
bla.diff (28.5 KB) - added by nomis 11 years ago.
avoid drawing superfluous decorations within tunnels/bridges.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by einarr

Attachment: 29691.png added

A tile illustrating the issue.

comment:1 Changed 11 years ago by nomis

I have implemented a prototypic solution for a similiar problem with bridges - see e.g. http://www.openstreetmap.org/?lat=50.89883&lon=8.02429&zoom=17&layers=0B0FTF . Bridges meeting in the air should not have fancy endings.

I'll attach a patch. I know that this solution has its drawbacks, but I think it goes in the right direction.

comment:2 Changed 11 years ago by nomis

Keywords: bridge added

Sorry - trac for some reasons fails to accept my patch.

It is available at http://www.home.unix-ag.org/simon/files/bridge-endings.patch

comment:3 Changed 11 years ago by nomis

Cc: nomis added

comment:4 Changed 11 years ago by Knut Arne Bjørndal

Cc: Knut Arne Bjørndal added

comment:5 Changed 11 years ago by nomis

Summary: Junctions in tunnelsJunctions in tunnels / on bridges

I'll attach a patch that fixes this behaviour as well as the bridge behaviour. With the help from bob I made a generic solution which now is used for tunnels as well as for bridges. The heuristics is now that the end-decoration is only drawn if there is exactly one way ending with bridge='yes' or tunnel='yes' respectively.

In case I don't manage to attach it again: http://www.home.unix-ag.org/simon/files/bridge-endings2.patch

Changed 11 years ago by nomis

Attachment: bla.diff added

avoid drawing superfluous decorations within tunnels/bridges.

comment:6 Changed 11 years ago by nomis

Cc: simon@… added; nomis removed

comment:7 Changed 11 years ago by bobkare

Resolution: fixed
Status: newclosed

(In [8789]) Applying patch from nomis, fixes #604

Note: See TracTickets for help on using tickets.