Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Upload order seems to be wrong when merging nodes #841

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments
Closed

Upload order seems to be wrong when merging nodes #841

openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments

Comments

@openstreetmap-trac
Copy link

Reporter: ColinMarquardt
[Submitted to the original trac issue database at 11.39pm, Wednesday, 16th April 2008]

A few times oin the past I had the effect that I got a status 412 from OSM when uploading edits.
When I try a second time, it uploads without a problem. The items left over for the second try are always "Remove trackpoint".

This happens to me when using the new "merge nodes" function (say I have e.g. a road and a separated wood area where I merge their nodes so that the road goes exactly along the edge of the wood).

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 1.44pm, Thursday, 17th April 2008]

Does that happen after loading from a .mdc or systematically?

Because I found a nasty bug regarding the history for merged nodes when reloading.

@openstreetmap-trac
Copy link
Author

Author: ColinMarquardt
[Added to the original trac issue at 2.48pm, Thursday, 17th April 2008]

I'm not loading from a .mdc file. It seems to happen systematically with the procedure above, but I confess I haven't done that test very, uhm, systematically.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 2.34pm, Friday, 18th April 2008]

I cannot reproduce.

If you could describe a step-by-step testcase, it would help

@openstreetmap-trac
Copy link
Author

Author: dantje
[Added to the original trac issue at 10.51am, Monday, 12th May 2008]

I also see this issue. When uploading the "REMOVE"s can not be applied, there is an error message that complains about the precondition. When I upload again, the remaining remove action are applied.

@openstreetmap-trac
Copy link
Author

Author: bvh
[Added to the original trac issue at 2.36pm, Monday, 19th May 2008]

(In [7863]) FIX : upload order when merging nodes
-> closes #841
The problem is merging two nodes that are part of two different roads will delete
one of them. But if the update of the road using that node is postponed to later
because another change the server will complain. The fix is to do all deletes
at the end in a seperate stage

@openstreetmap-trac
Copy link
Author

Author: ColinMarquardt
[Added to the original trac issue at 9.27pm, Monday, 19th May 2008]

I now have a case where this fix doesn't work (so maybe it's something different). I'm trying to delete way 24229285, but as soon as I do that and try to upload, I get an error 412, persistent this time.

This way resulted from a split with way 24422811 (to the southeast), where the node 251062854 that is shared between them is the result of a "Merge nodes" operation.

Maybe Merkaartor is working fine now but the data is strange because of my previous edits with Merkaartor there?

Also, I think way 2442281 is actually two ways using the exact same nodes - can Merkaartor display such cases, or possibly even edit them?

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 3.37pm, Thursday, 3rd July 2008]

Assume fixed in [8379]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant