Opened 11 years ago

Closed 11 years ago

#914 closed defect (fixed)

[patch] explicitly include linux.h in mod_tile to compile for gcc 4.3

Reported by: dylan.semler@… Owned by: Tom Hughes
Priority: minor Milestone: OSM 1.0
Component: utils Version:
Keywords: mod_tile, linux.h, gcc Cc:

Description

This patch explicitly adds #include <linux/linux.h> to speedtest.cpp and render_list.c in order to get mod_tile to compile with gcc 4.3.0.

Attachments (1)

mod_tile.diff (613 bytes) - added by dylan.semler@… 11 years ago.
Created with svn diff

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by dylan.semler@…

Attachment: mod_tile.diff added

Created with svn diff

comment:1 Changed 11 years ago by Tom Hughes

Can you clarify what it is in the code that requires the inclusion of linux/linux.h exactly - it shouldn't normally be necessary to include that in any user code, so I would like to see if there is a more portable solution to the problem you are encountering.

comment:2 Changed 11 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

OK - I think I've sorted this. I assume it was the PATH_MAX definition you were having problems with? That's what I was seeing on Fedora 9 though I'm not sure if gcc 4.3 or glibc 2.8 was the trigger.

The correct fix is to include limits.h rather than a linux specific file, and I have now committed that as r7866.

Note: See TracTickets for help on using tickets.