Opened 11 years ago

Closed 11 years ago

#915 closed defect (fixed)

Duplicate nodes on intermittent connections

Reported by: richard Owned by: richard@…
Priority: major Milestone:
Component: potlatch (flash editor) Version:
Keywords: Cc:

Description

  1. Create way A including a new node (say, -699)
  1. Deselect to start upload
  1. Create branching way B off node -699
  1. Deselect to start upload

If the way A upload hasn't returned by step 4, then node -699 will be sent again, and given a different ID this time.

Possible fixes: introduce some form of dependency (i.e. don't upload way B until way A's putway has returned), which is probably most sensible; go back afterwards and merge; or make node renumbering persist per user at an API level. May tie in with #897.

Change History (2)

comment:1 Changed 11 years ago by Richard

Priority: minormajor

I think the solution is:

  • add .ways to the node model, i.e. an array of way IDs containing this node
  • on attempted upload, for each node, check that it's not in a currently uploading way
  • (as usual, look for non-uploaded ways after each way completes)

Probably best combined with the move of .path from ids to object refs.

Will require a fair amount of code to maintain the .ways list for nodes. On the plus side, it makes the garbage collection easier for nodes.

comment:2 Changed 11 years ago by Richard

Resolution: fixed
Status: newclosed

Fixed in 0.10c.

Note: See TracTickets for help on using tickets.