Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Duplicate nodes on intermittent connections #915

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Duplicate nodes on intermittent connections #915

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Assignees
@openstreetmap-trac
Labels
Component: potlatch (flash editor) Priority: major Resolution: fixed Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: richard
[Submitted to the original trac issue database at 1.46am, Tuesday, 20th May 2008]

  1. Create way A including a new node (say, -699)

  2. Deselect to start upload

  3. Create branching way B off node -699

  4. Deselect to start upload

If the way A upload hasn't returned by step 4, then node -699 will be sent again, and given a different ID this time.

Possible fixes: introduce some form of dependency (i.e. don't upload way B until way A's putway has returned), which is probably most sensible; go back afterwards and merge; or make node renumbering persist per user at an API level. May tie in with #897.
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 9.07am, Thursday, 28th August 2008]

I think the solution is:

  • add .ways to the node model, i.e. an array of way IDs containing this node
  • on attempted upload, for each node, check that it's not in a currently uploading way
  • (as usual, look for non-uploaded ways after each way completes)

Probably best combined with the move of .path from ids to object refs.

Will require a fair amount of code to maintain the .ways list for nodes. On the plus side, it makes the garbage collection easier for nodes.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 3.36pm, Thursday, 18th September 2008]

Fixed in 0.10c.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: potlatch (flash editor) Priority: major Resolution: fixed Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac