Opened 11 years ago

Closed 5 years ago

#954 closed defect (wontfix)

Slash '/' does not work on German and Swiss-German keyboards

Reported by: remo.nospam@… Owned by: richard@…
Priority: major Milestone:
Component: potlatch (flash editor) Version:
Keywords: Cc:

Description

The slash to select another way does not work when I have set my keyboard to German or Swiss-German. It works as advertised when I set my keyboard to US. On the German and Swiss-German keyboard the slash is accessed with 'shift-7'. Is the fact that we have to use the shift key related to this bug?
My setup: Potlatch 0.9c on Flash WIN 9,0,124,0 on Firefox 2.0.0.14 on Windows 2000 SP4.
But I can see the same problem on my Vista laptop.

Change History (9)

comment:1 Changed 11 years ago by Richard

  • Resolution set to fixed
  • Status changed from new to closed

Ah - this is a documentation bug, sorry. If you press the key which would be '/' on a British keyboard (I think it's '-') then it should work. I'll fix the documentation.

comment:2 Changed 11 years ago by remo.nospam@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

The '-' is actually at the same position on the German and Swiss-German keyboard as the '/' is on the English keyboard. But pressing '-' does not select another way but it removes a point from the current way as the '-' on the English keyboard. So, it seems that 'select another way' acts on the position of the key and 'remove a point from the current way' act on the character value and 'remove a point from the current way' wins.

comment:3 Changed 11 years ago by Richard

Eek. Ok, this is all a bit weird.

Both act on the the key code, not the character code:

http://trac.openstreetmap.org/browser/applications/editors/potlatch/potlatch.as#L731

But it turns out that Flash behaves in an... interesting fashion with non-US/UK keyboards. (See http://oddhammer.com/index.php/site/comments/bug_input_language_issue_on_screen_keyboard/ , http://savannah.gnu.org/task/?7292 .)

Could you use http://oddhammer.com/tutorials/german.html and tell me what values you get for '/' and '-'? Thanks!

comment:4 Changed 11 years ago by remo.nospam@…

On my Swiss-German keyboard on Vista I get:
Input - /
getCode() 189 55
getAscii() 45 38
String.fromCharCode(Key.getAscii(()) - &

If I set the keyboard to German, I get the same.

comment:5 Changed 10 years ago by Richard

  • Resolution set to fixed
  • Status changed from reopened to closed

Should hopefully be fixed in 0.10 (awaiting deployment).

comment:6 Changed 10 years ago by remo.nospam@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

I have tried potlatch 0.10 today. With the German keyboard pressing '-' (where the '/' is on the UK keyboard) still deletes the point and pressing '/' (shift-7) does nothing. When I have set Windows to use the UK keymap, pressing '/' works as advertised.

Remo

comment:7 Changed 10 years ago by Richard

That's completely mad - http://trac.openstreetmap.org/browser/applications/editors/potlatch/potlatch.as#L641 clearly checks for the ASCII value of '/' now. I'll take a further look if I get a minute.

comment:8 Changed 10 years ago by Circeus

Have you considered supplementing th slash key with a alphanumeric one? It's not an actual bugfix, but at least it would allow everybody to use it without requiring too massive a reprogramming.

comment:9 Changed 5 years ago by iandees

  • Resolution set to wontfix
  • Status changed from reopened to closed

Cleaning aging tickets.

Note: See TracTickets for help on using tickets.