Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

API 0.6 requires history rethink (slightly) #967

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

API 0.6 requires history rethink (slightly) #967

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Richard
[Submitted to the original trac issue database at 12.22pm, Monday, 9th June 2008]

cf Black Forest, Montgomery.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 11.40pm, Monday, 24th November 2008]

Ok, this has changed slightly.

Revert does currently work on moved ways, as far as I can tell.

However, it won't as of API 0.6. This is because Potlatch will no longer write a new way revision if the way itself (i.e. node list + tags) hasn't changed. Consequently the getway_history call won't pick this up.

This means:

  • getway_history needs to look for node changes as well as just way changes (presumably assemble a BIG ARRAY OF CRAP and then sort the BIG ARRAY OF CRAP in date order)

  • it then needs to send timestamps, not version numbers, back to Potlatch

Let joy be unconfined.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 12.35pm, Thursday, 27th November 2008]

Also, need to give some thought to junction nodes. Working through #1377 it seems that shared nodes may not get preserved on revert.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 10.56pm, Monday, 15th December 2008]

Also also, getway_old needs to send back node versions.

Ah, the price you pay for being ahead of the curve...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant