Opened 12 years ago

Closed 11 years ago

#967 closed defect (fixed)

API 0.6 requires history rethink (slightly)

Reported by: Richard Owned by: richard@…
Priority: critical Milestone:
Component: potlatch (flash editor) Version:
Keywords: Cc:


cf Black Forest, Montgomery.

Change History (4)

comment:1 Changed 12 years ago by Richard

Summary: Revert does not work on moved waysAPI 0.6 requires history rethink (slightly)

Ok, this has changed slightly.

Revert does currently work on moved ways, as far as I can tell.

However, it won't as of API 0.6. This is because Potlatch will no longer write a new way revision if the way itself (i.e. node list + tags) hasn't changed. Consequently the getway_history call won't pick this up.

This means:

  • getway_history needs to look for node changes as well as just way changes (presumably assemble a BIG ARRAY OF CRAP and then sort the BIG ARRAY OF CRAP in date order)
  • it then needs to send timestamps, not version numbers, back to Potlatch

Let joy be unconfined.

comment:2 Changed 12 years ago by Richard

Also, need to give some thought to junction nodes. Working through #1377 it seems that shared nodes may not get preserved on revert.

comment:3 Changed 12 years ago by Richard

Also also, getway_old needs to send back node versions.

Ah, the price you pay for being ahead of the curve...

comment:4 Changed 11 years ago by Richard

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.