Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Joining roads results in upload error 412 "Precondition failed" #978

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 13 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: 0x02a[at]freenet.de
[Submitted to the original trac issue database at 6.16pm, Thursday, 12th June 2008]

  • Create a new road starting at an endpoint of an existing road.
  • Join these two roads.
  • Upload data.
  • Error message 412 "Precondition failed"
  • The newly created road is not uploaded.

100% reproducible in Merkaator 0.11 for Windows.

@openstreetmap-trac
Copy link
Author

Author: ColinMarquardt
[Added to the original trac issue at 7.51pm, Thursday, 12th June 2008]

Could Ticket #841 be related?

@openstreetmap-trac
Copy link
Author

Author: 0x02a[at]freenet.de
[Added to the original trac issue at 8.45pm, Thursday, 12th June 2008]

Probably yes. Although in this case nothing is actually merged. Or is it? Just the entire new road with all its nodes is missing after the upload.

BTW, joining and uploading works fine if both roads have been created in a previous session and were freshly downloaded.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 5.54pm, Tuesday, 17th June 2008]

I just tried and I didn't have the problem in SVN, so it could have been solved.

If you still have it, could you please save an MDC before upload and attach it...

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 3.39pm, Thursday, 3rd July 2008]

No response from reporter. Assume fixed.

@openstreetmap-trac
Copy link
Author

Author: 0x02a[at]freenet.de
[Added to the original trac issue at 8.16pm, Thursday, 7th August 2008]

Nope, this is not fully fixed. I just tried the same procedure with the current 0.11 build for Windows: the error message "precondition failed" still appears but the roads are joined correctly now.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 11.41pm, Thursday, 7th August 2008]

Would you be so very kind as to provide me with "the same procedure", then, that I could have a chance to reproduce.

Thanks

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 1.58am, Friday, 8th August 2008]

Nevermind, I didn't recheck the header.
Confirmed

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 11.41am, Friday, 8th August 2008]

(In [9563]) FIX : 412 when uploading joined/splitted roads (closes #978)

@openstreetmap-trac
Copy link
Author

Author: 0x02a[at]freenet.de
[Added to the original trac issue at 7.09pm, Friday, 8th August 2008]

Sorry, but I don't think this is actually fixed. I just repeated the following procedure:

  • download some data
  • start a new road beginning at an end point of an existing road
  • set the same tags on the new road
  • select the existing road, ctrl-select the new road
  • Alt+J for joining the roads
  • Upload data: "precondition failed", the add road task remains in the upload list

The only difference I see from the 0.11pre release to the current release candidate is that the two roads are joined now correctly (verified this by downloading data again). Just the error task remains in the upload list forever and will always pop up the error message.

I noticed that the order of selecting the two roads to be joined is important. It worked fine when I first selected the new road and then the existing one.

So the fix is probably half done...

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 10.37am, Saturday, 9th August 2008]

Are you speaking latest SVN or merkaartor-0.11-fixes ?

@openstreetmap-trac
Copy link
Author

Author: 0x02a[at]freenet.de
[Added to the original trac issue at 1.19pm, Saturday, 9th August 2008]

I'm referring to the latest available WINDOWS build (0.11). Dunno if this is 0.11-fixes.
Fine if this was already fixed...

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 7.43pm, Monday, 15th September 2008]

Could you please retest with 0.12beta1...

@openstreetmap-trac
Copy link
Author

Author: osm[at]mocacher.de
[Added to the original trac issue at 8.06pm, Monday, 15th September 2008]

Confirmed. This is definitely fixed!
I tried both orders of selecting the roads (see above) and joining the roads works without errors.
Great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant