Opened 10 years ago

Closed 10 years ago

#978 closed defect (fixed)

Joining roads results in upload error 412 "Precondition failed"

Reported by: 0x02a@… Owned by: koying
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

  • Create a new road starting at an endpoint of an existing road.
  • Join these two roads.
  • Upload data.
  • Error message 412 "Precondition failed"
  • The newly created road is not uploaded.

100% reproducible in Merkaator 0.11 for Windows.

Change History (13)

comment:1 Changed 10 years ago by ColinMarquardt

Could Ticket #841 be related?

comment:2 Changed 10 years ago by 0x02a@…

Probably yes. Although in this case nothing is actually merged. Or is it? Just the entire new road with all its nodes is missing after the upload.

BTW, joining and uploading works fine if both roads have been created in a previous session and were freshly downloaded.

comment:3 Changed 10 years ago by koying

I just tried and I didn't have the problem in SVN, so it could have been solved.

If you still have it, could you please save an MDC before upload and attach it...

comment:4 Changed 10 years ago by koying

  • Resolution set to fixed
  • Status changed from new to closed

No response from reporter. Assume fixed.

comment:5 Changed 10 years ago by 0x02a@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

Nope, this is not fully fixed. I just tried the same procedure with the current 0.11 build for Windows: the error message "precondition failed" still appears but the roads are joined correctly now.

comment:6 Changed 10 years ago by koying

  • Owner changed from bvh-osm@… to koying
  • Status changed from reopened to new

Would you be so very kind as to provide me with "the same procedure", then, that I could have a chance to reproduce.

Thanks

comment:7 Changed 10 years ago by koying

  • Status changed from new to assigned

Nevermind, I didn't recheck the header.
Confirmed

comment:8 Changed 10 years ago by koying

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [9563]) FIX : 412 when uploading joined/splitted roads (closes #978)

comment:9 Changed 10 years ago by 0x02a@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, but I don't think this is actually fixed. I just repeated the following procedure:

  • download some data
  • start a new road beginning at an end point of an existing road
  • set the same tags on the new road
  • select the existing road, ctrl-select the new road
  • Alt+J for joining the roads
  • Upload data: "precondition failed", the add road task remains in the upload list

The only difference I see from the 0.11pre release to the current release candidate is that the two roads are joined now correctly (verified this by downloading data again). Just the error task remains in the upload list forever and will always pop up the error message.

I noticed that the order of selecting the two roads to be joined is important. It worked fine when I first selected the new road and then the existing one.

So the fix is probably half done...

comment:10 Changed 10 years ago by koying

Are you speaking latest SVN or merkaartor-0.11-fixes ?

comment:11 Changed 10 years ago by 0x02a@…

I'm referring to the latest available WINDOWS build (0.11). Dunno if this is 0.11-fixes.
Fine if this was already fixed...

comment:12 Changed 10 years ago by koying

Could you please retest with 0.12beta1...

comment:13 Changed 10 years ago by osm@…

  • Resolution set to fixed
  • Status changed from reopened to closed

Confirmed. This is definitely fixed!
I tried both orders of selecting the roads (see above) and joining the roads works without errors.
Great!

Note: See TracTickets for help on using tickets.