Opened 9 years ago

Closed 5 years ago

#3043 closed enhancement (duplicate)

Rendering a generic shop icon

Reported by: John Owned by: mapnik-team@…
Priority: major Milestone:
Component: mapnik Version:
Keywords: Cc: pnorman

Description

Currently only a limited subset of shops render at all, it would be nice to have a generic shop icon render if any sort of shop=* tag is present if nothing more specific is already described in the mapnik style sheet.

Attachments (3)

shop-car.png (463 bytes) - added by fluteflute 9 years ago.
shop.png (250 bytes) - added by Jan 9 years ago.
shop.svg (2.4 KB) - added by Jan 9 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by Pieren

This is something I wanted in the past. But when I see the result now on google maps, it's a real bad idea : the street names disappear behind business information ! It's not my concept of the main OSM showcase as Mapnik is currently. That can be done somewhere else.

comment:2 in reply to:  1 Changed 9 years ago by John

Replying to Pieren:

This is something I wanted in the past. But when I see the result now on google maps, it's a real bad idea : the street names disappear behind business information ! It's not my concept of the main OSM showcase as Mapnik is currently. That can be done somewhere else.

This is the benefit of having data available, not just tiles which you can put icons on top of, mapnik will shift the name of the street out of the way so the icon and the name don't overlap, also a lot of shops are off the road so shouldn't interfere too much if they are placed properly, google seems to do a lot of geocoding and places icons directly on top of the road ways.

comment:3 Changed 9 years ago by Waldo000000

Two things: 1) This is more likely to happen if you can find/propose a suitable "generic shop icon" 2) Care should be taken in mapnik to only render these "generic" icons when they do not interfere with other (already rendered) features. i.e. Presumably, POI's that are specifically/specially rendered already are more "important" than these generic icons. That is, when a collision occurs, presumably the "generic" icon should be hidden to make way for the other feature(s).

comment:4 in reply to:  3 Changed 9 years ago by John

Replying to Waldo000000:

Two things: 1) This is more likely to happen if you can find/propose a suitable "generic shop icon"

I posted this in part to get ideas about what people think a generic shop icon would look like, would a hand basket be good enough, or a shopping cart, or ... ?

2) Care should be taken in mapnik to only render these "generic" icons when they do not interfere with other (already rendered) features. i.e. Presumably, POI's that are specifically/specially rendered already are more "important" than these generic icons. That is, when a collision occurs, presumably the "generic" icon should be hidden to make way for the other feature(s).

mapnik can handle if then else, so this would be a last resort if nothing else was rendered, my hope is if something renders, rather than nothing, people will enter a lot more POIs because they then show up on a map.

Changed 9 years ago by fluteflute

Attachment: shop-car.png added

comment:5 Changed 9 years ago by fluteflute

Sorry, added that attachment to the wrong ticket!

comment:6 Changed 9 years ago by Jan

I'd suggest using a simple circle as generic shop icon, as a shopping basket is already used for a specific shop.

And I think that in most cases, when there are many shops, it would be better to display only the icon instead of nothing if it wouldn't fit as icon plus text. So in the lower zoom levels the text should never be displayed, as it would probably hide the street underneath, and only the more important shops should be displayed. When zooming in, more and more shops should be displayed and for the important shops the names should come in. In the highest zoom mode, all shops should be visible, and (if possible) all shops should be displayed as icon plus text. An additional zoom level would be great for this, but probably it would be a problem because of limited resources.

Changed 9 years ago by Jan

Attachment: shop.png added

Changed 9 years ago by Jan

Attachment: shop.svg added

comment:7 Changed 8 years ago by richlv

any chance to get this in ? would increase motivation to actually map shops that are not in one of the generally recognised categories, and would also allow to get real life exposure for shop tags not "approved" on the wiki

comment:8 Changed 8 years ago by pnorman

Cc: pnorman added

comment:9 Changed 8 years ago by richlv

this seems to be undeservedly ignored :)

when mapping, lots of shops do not fall under the quite narrow range that is recognised by the mapnik layer. this, of course, takes out a bit of motivation.

for example, http://www.openstreetmap.org/?lat=30.38945&lon=-97.732099&zoom=18&layers=M would be more useful if it rendered a bit more shops that are already mapped.\

i believe this would also server as a (minor, but still) motivator to introduce more people to osm ("hey, your shop is on osm, maybe worth to add a map to your homepage").

comment:10 Changed 6 years ago by oddityoverseer

I just commited a change to the openstreetmap-carto project resolving this bug: https://github.com/gravitystorm/openstreetmap-carto/pull/117

comment:11 Changed 5 years ago by math1985

Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.