Ticket #3980 (new enhancement)

Opened 3 years ago

Last modified 2 years ago

RFE: Potlatch/2 feature to ease correct node<->way conversions

Reported by: bryce2@… Owned by: potlatch-dev@…
Priority: minor Milestone:
Component: potlatch2 Version:
Keywords: Cc:

Description

This is a request from a data-import concern with osm:


A frequent enough use case is seeing a point feature and converting it to an outline. For example a named historic landmark that's a point, but is turned into a building outline.

Imagine instead two new action buttons in the bottom right corner of Potlatch/2:

Convert node --> area Convert area --> node

The node would turn into a small square area. An area would be collapsed into a point feature at the centroid. The concept works well as an icon.

Presently this operation can be fragile, as beginner mappers may destroy the point's keys in the conversion from node --> area. If the destroyed key documents a primary key from an import, it becomes harder to re-reconcile the import with the original data source.

The 'R' key presently does not work for this, though JOSM does have shortcut. But even the 'R' key is much more obscure compared to the proposed action button.

Change History

comment:1 Changed 3 years ago by bryce2@…

(This can be done by clicking a node and shift-clicking elsewhere. I'm proposing something more easily discovered).

comment:2 Changed 3 years ago by Richard

  • Priority changed from critical to minor

Given that it can already be done, this is really a documentation issue rather than a feature request. Also, no way is this 'critical'. ;)

comment:3 Changed 3 years ago by bryce2@…

Let's call it "discovery" not "documentation". People discover features of tools: sometimes by reading documentation, sometimes by seeing a button or control and using it.

--- The feature itself is small, the importance is the potential reduction in damage to tags.

comment:4 Changed 3 years ago by Richard

You can call it whatever you like if you're the one who supplies a good-quality patch. ;) But "critical" means "this will cause your computer to catch fire" (and "blocker" means "and it will also ignite the rest of your house").

FWIW, I think the toolbox probably needs to get a disclosure triangle so that the top four items (delete, direction, split, merge) are always visible and the less important remainder can be revealed on user action. I'm not planning to allow any more toolbox items until we've implemented this.

comment:5 Changed 3 years ago by bryce2@…

I'll be first in line to submit patches once potlatch/2 is refactored into perl, python, javascript, java, c, 68000 assembly language, or xslt :-).

FWIW: I think you'll eventually want a disclosure triangle, but right now potlach's interface is sparse and clean enough it can survive a bit more clutter. There are various operations that are somewhat hidden by the interface that would pop out as buttons.

comment:6 follow-up: ↓ 7 Changed 3 years ago by sleske

Just for the record, the workaround proposed in the first commment ("clicking a node and shift-clicking elsewhere") does not work for me. Should I file a separate bug for this?

Also, the workaround does not appear to be documented anywhere. Should I file a bug for this as well?

comment:7 in reply to: ↑ 6 Changed 2 years ago by skorasaurus

Replying to sleske:

Just for the record, the workaround proposed in the first commment ("clicking a node and shift-clicking elsewhere") does not work for me. Should I file a separate bug for this?

Also, the workaround does not appear to be documented anywhere. Should I file a bug for this as well?

The workaround that Bryce mentioned in comment 1, works for me.

Although this may be a separate, very related feature request, I was copying a single node's properties [an island] and have it apply to the entire island's coastline and according to Bryce's workaround, I would have to significantly retrace the island using the created box. A user could manually enter the node's tags into the coastline but a shortcut mentioned at  https://trac.openstreetmap.org/ticket/3811 would be helpful for this task.

Note: See TracTickets for help on using tickets.