Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

RFE: Potlatch/2 feature to ease correct node<->way conversions #3980

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments
Open

Comments

@openstreetmap-trac
Copy link

Reporter: bryce2[at]obviously.com
[Submitted to the original trac issue database at 11.46pm, Thursday, 25th August 2011]

This is a request from a data-import concern with osm:


A frequent enough use case is seeing a point feature and converting it to an outline. For example a named historic landmark that's a point, but is turned into a building outline.

Imagine instead two new action buttons in the bottom right corner of Potlatch/2:
Convert node --> area
Convert area --> node
The node would turn into a small square area. An area would be collapsed into a point feature at the centroid. The concept works well as an icon.

Presently this operation can be fragile, as beginner mappers may destroy the point's keys in the conversion from node --> area. If the destroyed key documents a primary key from an import, it becomes harder to re-reconcile the import with the original data source.

The 'R' key presently does not work for this, though JOSM does have shortcut. But even the 'R' key is much more obscure compared to the proposed action button.

@openstreetmap-trac
Copy link
Author

Author: bryce2[at]obviously.com
[Added to the original trac issue at 4.49am, Friday, 26th August 2011]

(This can be done by clicking a node and shift-clicking elsewhere. I'm proposing something more easily discovered).

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 7.36am, Friday, 26th August 2011]

Given that it can already be done, this is really a documentation issue rather than a feature request. Also, no way is this 'critical'. ;)

@openstreetmap-trac
Copy link
Author

Author: bryce2[at]obviously.com
[Added to the original trac issue at 9.08am, Friday, 26th August 2011]

Let's call it "discovery" not "documentation". People discover features of tools: sometimes by reading documentation, sometimes by seeing a button or control and using it.


The feature itself is small, the importance is the potential reduction in damage to tags.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 9.19am, Friday, 26th August 2011]

You can call it whatever you like if you're the one who supplies a good-quality patch. ;) But "critical" means "this will cause your computer to catch fire" (and "blocker" means "and it will also ignite the rest of your house").

FWIW, I think the toolbox probably needs to get a disclosure triangle so that the top four items (delete, direction, split, merge) are always visible and the less important remainder can be revealed on user action. I'm not planning to allow any more toolbox items until we've implemented this.

@openstreetmap-trac
Copy link
Author

Author: bryce2[at]obviously.com
[Added to the original trac issue at 11.07pm, Friday, 26th August 2011]

I'll be first in line to submit patches once potlatch/2 is refactored into perl, python, javascript, java, c, 68000 assembly language, or xslt :-).

FWIW: I think you'll eventually want a disclosure triangle, but right now potlach's interface is sparse and clean enough it can survive a bit more clutter. There are various operations that are somewhat hidden by the interface that would pop out as buttons.

@openstreetmap-trac
Copy link
Author

Author: sleske
[Added to the original trac issue at 10.19pm, Saturday, 22nd October 2011]

Just for the record, the workaround proposed in the first commment ("clicking a node and shift-clicking elsewhere") does not work for me. Should I file a separate bug for this?

Also, the workaround does not appear to be documented anywhere. Should I file a bug for this as well?

@openstreetmap-trac
Copy link
Author

Author: skorasaurus
[Added to the original trac issue at 3.12pm, Sunday, 13th May 2012]

Replying to [comment:6 sleske]:

Just for the record, the workaround proposed in the first commment ("clicking a node and shift-clicking elsewhere") does not work for me. Should I file a separate bug for this?

Also, the workaround does not appear to be documented anywhere. Should I file a bug for this as well?

The workaround that Bryce mentioned in comment 1, works for me.

Although this may be a separate, very related feature request, I was copying a single node's properties [an island] and have it apply to the entire island's coastline and according to Bryce's workaround, I would have to significantly retrace the island using the created box. A user could manually enter the node's tags into the coastline but a shortcut mentioned at https://trac.openstreetmap.org/ticket/3811 would be helpful for this task.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant