Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

URLs should not be linked in changeset titles in lists of changesets #5061

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: aseerel4c26
[Submitted to the original trac issue database at 1.42pm, Friday, 6th December 2013]

Look at my first to changesets of today at http://www.openstreetmap.org/user/aseerel4c26/history http://www.openstreetmap.org/changeset/19336756
and http://www.openstreetmap.org/changeset/19338848

At the first you may accidentally click the link because there is nearly no visual difference from the description text.

At the second you cannot open thing changeset in a new tab since there is no real link to it. You may be able to open it via JavaScript if you realize that you can click on somewhere outside of the description text (the whole box of this changeset in the list).

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 1.15pm, Sunday, 8th December 2013]

Fixed in [changeset:5c53bb7/rails] by removing linkification in the changeset list, and adding it in the detail view for a changeset.

@openstreetmap-trac
Copy link
Author

Author: aseerel4c26
[Added to the original trac issue at 1.34pm, Sunday, 8th December 2013]

Thank you, works!

I had thought that the links already were clickable in the "detail view for a changeset". Hmm, I may remember wrongly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant