Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

[landcover] Render embankment=yes instead of man_made=embankment #963

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: jttt
[Submitted to the original trac issue database at 6.53am, Monday, 9th June 2008]

Mapnik renders embankments only when tagged as man_made=embankment, but Map Features page say embankment=yes should be used. man_made=embankment is not documented anywhere on wiki except natural=cliff.

I suggest to change rendering rules to render embankment=yes (and maybe remove man_made=embankment).

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 7.43am, Monday, 9th June 2008]

Well a first step would probably be to try and get the people behind the two different tagging schemes to discuss it and come to a conclusion...

@openstreetmap-trac
Copy link
Author

Author: jttt
[Added to the original trac issue at 9.14am, Monday, 9th June 2008]

embankment=yes is already on Map Features page and it's used 830 times in planet.osm. man_made=embankment is not documented and it's used 4 times.

I thought that having man_made=embankment in mapnik's rendering rules is rather a mistake than a new tagging scheme.

@openstreetmap-trac
Copy link
Author

Author: steve8[at]mdx.ac.uk
[Added to the original trac issue at 5.22pm, Sunday, 15th June 2008]

Can you point me to a couple of instances of embankment=yes (preferably in UK as that is my standard test db)? Presume that like bridge=yes it is in combination with one or more other tags. How many and what are they? I will then have a look.

@openstreetmap-trac
Copy link
Author

Author: jttt
[Added to the original trac issue at 5.38pm, Sunday, 15th June 2008]

You can download all elements with embankment here: [http://jttt.110mb.com/embankment.osm]. Note that embankment=false and similar tags are included as well. I got that file from XAPI but XAPI was dead in last few days so I can't provide current data.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 11.10pm, Tuesday, 18th August 2009]

Visualization of elements alongside (parallel to) a way should be possible in mapnik sometime in the near future. Currently it's hard to implement this, as the embankment lines would be hidden under the actual ways they pertain to.

@openstreetmap-trac
Copy link
Author

Author: Mueck
[Added to the original trac issue at 2.45pm, Sunday, 7th November 2010]

Reminder ;-)

http://taginfo.openstreetmap.de/keys/man_made
--> 288x man_made=embankment
not in wiki
--> 1358x man_made=dyke
http://wiki.openstreetmap.org/wiki/Tag:man_made=dyke

http://taginfo.openstreetmap.de/keys/embankment
--> 15065x embankment=yes
http://wiki.openstreetmap.org/wiki/Key:embankment

(and as opposite:
http://taginfo.openstreetmap.de/keys/cutting
--> 11186x cutting=yes
http://wiki.openstreetmap.org/wiki/Key:cutting )

@openstreetmap-trac
Copy link
Author

Author: math1985
[Added to the original trac issue at 4.28pm, Monday, 28th July 2014]

This issue is now being discussed on Github: gravitystorm/openstreetmap-carto#791

Therefore, I will close the issue here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant