Opened 11 years ago

Closed 5 years ago

#963 closed enhancement (duplicate)

[landcover] Render embankment=yes instead of man_made=embankment

Reported by: jttt Owned by: mapnik-team@…
Priority: major Milestone:
Component: mapnik Version:
Keywords: Cc:

Description

Mapnik renders embankments only when tagged as man_made=embankment, but Map Features page say embankment=yes should be used. man_made=embankment is not documented anywhere on wiki except natural=cliff.

I suggest to change rendering rules to render embankment=yes (and maybe remove man_made=embankment).

Change History (8)

comment:1 Changed 11 years ago by Tom Hughes

Owner: changed from Tom Hughes to steve8@…

Well a first step would probably be to try and get the people behind the two different tagging schemes to discuss it and come to a conclusion...

comment:2 Changed 11 years ago by jttt

embankment=yes is already on Map Features page and it's used 830 times in planet.osm. man_made=embankment is not documented and it's used 4 times.

I thought that having man_made=embankment in mapnik's rendering rules is rather a mistake than a new tagging scheme.

comment:3 Changed 11 years ago by steve8@…

Can you point me to a couple of instances of embankment=yes (preferably in UK as that is my standard test db)? Presume that like bridge=yes it is in combination with one or more other tags. How many and what are they? I will then have a look.

comment:4 Changed 11 years ago by jttt

You can download all elements with embankment here: http://jttt.110mb.com/embankment.osm. Note that embankment=false and similar tags are included as well. I got that file from XAPI but XAPI was dead in last few days so I can't provide current data.

comment:5 Changed 10 years ago by Ldp

Owner: changed from steve8@… to mapnik-team@…

Visualization of elements alongside (parallel to) a way should be possible in mapnik sometime in the near future. Currently it's hard to implement this, as the embankment lines would be hidden under the actual ways they pertain to.

comment:7 Changed 5 years ago by math1985

Summary: [mapnik] Render embankment=yes instead of man_made=embankment[landcover] Render embankment=yes instead of man_made=embankment

comment:8 Changed 5 years ago by math1985

Resolution: duplicate
Status: newclosed

This issue is now being discussed on Github: https://github.com/gravitystorm/openstreetmap-carto/issues/791

Therefore, I will close the issue here.

Note: See TracTickets for help on using tickets.